Hi Marc,
On Thu, 14 Aug 2025 at 14:08, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
> On 14.08.2025 14:02:01, Geert Uytterhoeven wrote:
> > The R-Car CAN module is part of a Clock Domain on all supported SoCs.
> > Hence convert its driver from explicit clock management to Runtime PM.
>
> Does kconfig ensure that Runtime PM is selected?
drivers/soc/renesas/Kconfig:
config ARCH_RCAR_GEN1
bool
select PM
config ARCH_RCAR_GEN2
bool
select HAVE_ARM_ARCH_TIMER
select PM
config ARCH_RCAR_GEN3
bool
select PM
> > --- a/drivers/net/can/rcar/rcar_can.c
> > +++ b/drivers/net/can/rcar/rcar_can.c
> > @@ -506,10 +506,10 @@ static int rcar_can_open(struct net_device *ndev)
> > struct rcar_can_priv *priv = netdev_priv(ndev);
> > int err;
> >
> > - err = clk_prepare_enable(priv->clk);
> > + err = pm_runtime_resume_and_get(ndev->dev.parent);
> > if (err) {
> > netdev_err(ndev,
> > - "failed to enable peripheral clock, error %d\n",
> > + "pm_runtime_resume_and_get() failed, error %d\n",
>
> Can you convert the errors to %pE?
Sure, will do!
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
