Hi Marc,
On Thu, 14 Aug 2025 at 14:08, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> wrote:
> On 14.08.2025 13:26:37, Geert Uytterhoeven wrote:
> > On R-Car Gen3 using PSCI, s2ram powers down the SoC. After resume, the
> > CAN interface no longer works, until it is brought down and up again.
> >
> > Fix this by calling rcar_can_start() from the PM resume callback, to
> > fully initialize the controller instead of just restarting it.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Can you add a fixes tag?
Well, the issue is more like an integration/platform issue: before the
advent of PSCI system suspend powering down the SoC, s2ram worked fine.
One might consider the (rudimentary) addition of support for R-Car
Gen3 to the driver as the first "broken" commit:
Fixes: e481ab23c57b37c9 ("can: rcar_can: Add r8a7795 support")
But at that time, Linux didn't even support wake-up from PSCI system
suspend on R-Car Gen3 systems...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
