Hi Biju,
On Thu, 14 Aug 2025 at 08:08, Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > From: Chris Brandt <Chris.Brandt@xxxxxxxxxxx>
> > > > + /* If foutvco is above 1.5GHz, change parent and recalculate */
> > > > + if (priv->mux_dsi_div_params.clksrc && (foutvco_rate >
> > > > +1500000000)) {
> > >
> > > Check patch is complaining:
> > >
> > > CHECK: Unnecessary parentheses around 'foutvco_rate > 1500000000'
> > > #146: FILE: drivers/clk/renesas/rzg2l-cpg.c:648:
> > > + if (priv->mux_dsi_div_params.clksrc && (foutvco_rate > 1500000000))
> > > +{
> >
> > I saw that...but I thought the ( ) makes it a little easier to read.
> >
> > But, what's the general rule here? Make checkpatch come out perfect?
> > What's your thoughts?
>
> I just ran check patch and it complained this.
> I am leaving Geert to comment on this.
/me chimes in ;-)
You are not required to fix checkpatch warnings or errors if you have a
good reason to do so. In this case, I see no reason for the parentheses
(it is not a very complex expression), so please drop them.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
