Hi Geert,
Thank you for the review.
On Wed, Aug 6, 2025 at 3:59 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> On Tue, 5 Aug 2025 at 14:25, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Add initial support for the Renesas RZ/T2H SoC to the R-Car Gen3 USB2 PHY
> > driver. The RZ/T2H SoC requires configuration of additional
> > hardware-specific bits for proper VBUS level control and OTG operation.
> >
> > Introduce the `vblvl_ctrl` flag in the SoC-specific driver data to enable
> > handling of VBUS level selection logic using `VBCTRL.VBLVL` bits. This is
> > required for managing the VBUS status detection and drive logic based on
> > SoC-specific needs.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c
> > +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c
>
> > @@ -284,6 +293,21 @@ static void rcar_gen3_init_from_a_peri_to_a_host(struct rcar_gen3_chan *ch)
> >
> > static bool rcar_gen3_check_id(struct rcar_gen3_chan *ch)
> > {
> > + if (ch->drvdata->vblvl_ctrl) {
> > + bool vbus_valid = false;
> > + bool device = false;
>
> No need to preinitialize these two variables.
>
Agreed, I will drop it.
> > +
> > + device = !!(readl(ch->base + USB2_ADPCTRL) & USB2_ADPCTRL_IDDIG);
> > + vbus_valid = !!(readl(ch->base + USB2_ADPCTRL) & USB2_ADPCTRL_VBUSVALID);
> > +
> > + if (device && vbus_valid)
> > + return true;
> > + else if (!device && vbus_valid)
>
> No need for else after return, but...
>
> > + return false;
> > +
> > + return !(device && !vbus_valid);
>
> ... all logic above can be simplified to
>
> return vbus_valid ? device : !device;
>
Ahha thanks for the pointer!
Cheers,
Prabhakar
