Hi Jacopo, Thank you for the patch! On Sat, Aug 02, 2025 at 11:22:40AM +0200, Jacopo Mondi wrote: > The RZ G2/L CRU driver sets file->private_data to the driver-specific The RZ/G2L > structure, but the following call to v4l2_fh_open() overwrites it > with a pointer to the just allocated v4l2_fh. > > Remove the mis-leading assignment in the driver. > > Signed-off-by: Jacopo Mondi <jacopo.mondi@xxxxxxxxxxxxxxxx> Apart from that: Tested-by: Tommaso Merciai <tommaso.merciai.xr@xxxxxxxxxxxxxx> Reviewed-by: Tommaso Merciai <tommaso.merciai.xr@xxxxxxxxxxxxxx> > --- > drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > index a8817a7066b22f8a8dd1fdab50efabc486e4dfdb..941badc90ff55c5225644f88de1d70239eb3a247 100644 > --- a/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > +++ b/drivers/media/platform/renesas/rzg2l-cru/rzg2l-video.c > @@ -1078,7 +1078,6 @@ static int rzg2l_cru_open(struct file *file) > if (ret) > return ret; > > - file->private_data = cru; > ret = v4l2_fh_open(file); > if (ret) > goto err_unlock; > > -- > 2.49.0 > Thanks & Regards, Tommaso
