Re: [PATCH] usb: gadget: udc: renesas_usb3: drop unused module alias

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

On Mon, Jul 28, 2025 at 10:56:18AM +0200, Geert Uytterhoeven wrote:

> On Thu, 24 Jul 2025 at 11:21, Johan Hovold <johan@xxxxxxxxxx> wrote:
> > Since commit f3323cd03e58 ("usb: gadget: udc: renesas_usb3: remove R-Car
> > H3 ES1.* handling") the driver only supports OF probe so drop the unused
> > platform module alias.
> >
> > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> 
> While I don't debate the actual change, I would like to comment on
> the patch description.  The driver only ever supported OF probe.
> The call to soc_device_match() was just used to override the match
> data for quirk handling.

The driver initially indeed only supported OF probe, but that changed
with commit ca02a5af650c ("usb: gadget: udc: renesas_usb3: Use
of_device_get_match_data() helper") after which the driver could at
least theoretically also bind based on the platform device name.

Johan




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux