On Tue, Jul 29, 2025 at 09:11:46AM +0200, Geert Uytterhoeven wrote:
> Hi Greg,
>
> On Tue, 29 Jul 2025 at 07:03, Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Tue, Jul 29, 2025 at 05:09:55AM +0200, Marek Vasut wrote:
> > > On 7/28/25 6:18 AM, Greg Kroah-Hartman wrote:
> > >
> > > [...]
> > >
> > > > > Fixes: 2478be82de44 ("usb: renesas-xhci: Add ROM loader for uPD720201")
> > > > > Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxxxx>
> > > > > ---
> > > > > Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > > > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > > > Cc: Mathias Nyman <mathias.nyman@xxxxxxxxx>
> > > > > Cc: Vinod Koul <vkoul@xxxxxxxxxx>
> > > > > Cc: <stable@xxxxxxxxxxxxxxx>
> > >
> > > [...]
> > >
> > > > - You have marked a patch with a "Fixes:" tag for a commit that is in an
> > > > older released kernel, yet you do not have a cc: stable line in the
> > > > signed-off-by area at all, which means that the patch will not be
> > > > applied to any older kernel releases. To properly fix this, please
> > > > follow the documented rules in the
> > > > Documentation/process/stable-kernel-rules.rst file for how to resolve
> > > > this.
> > >
> > > Maybe the bot should take into consideration Cc: stable below the --- too ?
> > > Or is that considered invalid ?
> >
> > That is totally invalid, it gets cut off when the patch is applied and
> > then is lost :(
>
> But the "Fix" keyword in the oneline-summary and the "Fixes" tag are
> not, so your stable minions will still take it ;-)
{sigh}
No, please NEVER rely on that. Grabbing "Fixes:" only patches are a
"best effort" thing that we do that is not reliable at all, AND you
never get a FAILED notification if something does not actually apply
properly.
The documentation clearly states how to mark something for the stable
tree, and that is NOT by only haveing a "Fixes:" tag in the commit.
thanks,
greg k-h
