Hi Wolfram Sang, Thanks for the feedback. > -----Original Message----- > From: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > Sent: 21 July 2025 12:25 > Subject: Re: [PATCH RFC/RFT 1/2] mmc: tmio: Add 64-bit read/write support for SD_BUF0 in polling mode > > > > Maybe I can guard these functions/caller using CONFIG_ARM64 as it is > > applicable only to GEN3 Platforms. Similar issue seen on [1]?? > > > > [1] https://lkml.iu.edu/hypermail/linux/kernel/2209.2/04657.html > > Maybe just use 64BIT as the guard? Seems a tad more precise to me. > > Other than that, looks good to me: > > Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > > Wasn't able to test this yet, though, sorry. I hope for tomorrow, but no promises. Ok, will guard like this in next version. #ifdef CONFIG_64BIT static inline void sd_ctrl_read64_rep(struct tmio_mmc_host *host, int addr, u64 *buf, int count) { ioread64_rep(host->ctl + (addr << host->bus_shift), buf, count); } static inline void sd_ctrl_write64_rep(struct tmio_mmc_host *host, int addr, const u64 *buf, int count) { iowrite64_rep(host->ctl + (addr << host->bus_shift), buf, count); } #else static inline void sd_ctrl_read64_rep(struct tmio_mmc_host *host, int addr, u64 *buf, int count) { } static inline void sd_ctrl_write64_rep(struct tmio_mmc_host *host, int addr, const u64 *buf, int count) { } #endif Cheers, Biju
