On Thu, Jun 26, 2025 at 11:11:24AM +0200, Wolfram Sang wrote: > On Wed, Jun 25, 2025 at 04:30:36PM -0400, Frank Li wrote: > > On Wed, Jun 25, 2025 at 03:09:19PM +0200, Wolfram Sang wrote: > > > This checkpatch warning makes sense here: "ENOTSUPP is not a SUSV4 error > > > code, prefer EOPNOTSUPP" We don't have a userspace interface yet, but we > > > probably will get one. So, let's convert these error codes now, before > > > it will be forgotten in the future, and they could slip through to > > > applications. > > > > I suggest the simple words should be enough. > > > > i3c: core: replace ENOTSUPP with SUSV4-compliant EOPNOTSUPP > > > > Replace non-standard ENOTSUPP with the SUSV4-defined error code EOPNOTSUPP > > to fix below checkpatch warning: > > "ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP" > > Can do so, if you really want, but "to fix checkpatch warning" is > usually a not-so-good commit description. The error message "ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP" is straightforward enough. Frank > The above text tells WHY > checkpatch issues the warning and why we should care. However, I can > probably simplify the wording a little. >
