Hi Prabhakar, On Fri, 20 Jun 2025 at 14:10, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Introduce device tree overlays to support the eMMC (RTK0EF0186B02000BJ) > and microSD (RTK0EF0186B01000BJ) sub-boards via the CN15 connector on the > RZ/V2H EVK. These overlays make use of shared DTSI fragments > (`rzv2-evk-cn15-emmc-common.dtsi` and `rzv2-evk-cn15-sd-common.dtsi`) > that encapsulate common CN15-specific configurations, including pinctrl > settings, SDHI0 setup, and required regulators. > > Additionally, the base board DTS is updated to define an `mmc0` alias > pointing to `&sdhi0`, and to add a fixed 1.8V regulator node (`reg_1p8v`) > intended for use by the optional eMMC sub-board and, in the future, the > ADV7535 HDMI encoder (not yet enabled in the DTS). > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk-cn15-emmc.dtso > @@ -0,0 +1,15 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Device Tree overlay for the RZ/V2H EVK with the eMMC sub-board > + * (RTK0EF0186802000BJ) connected to the CN15 connector. > + * > + * Copyright (C) 2025 Renesas Electronics Corp. > + */ > + > +/dts-v1/; > +/plugin/; > + > +#define RZV2H_PA 10 > +#define EMMC_GPIO(port, pin) RZG2L_GPIO(RZV2H_P##port, pin) > + > +#include "rzv2-evk-cn15-emmc-common.dtsi" > diff --git a/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk-cn15-sd.dtso b/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk-cn15-sd.dtso > new file mode 100644 > index 000000000000..47cb581c1add > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk-cn15-sd.dtso > @@ -0,0 +1,16 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Device Tree overlay for the RZ/V2H EVK with the SD sub-board > + * (RTK0EF0186B01000BJ) connected to the CN15 connector. > + * > + * Copyright (C) 2025 Renesas Electronics Corp. > + */ > + > +/dts-v1/; > +/plugin/; > + > +#define RZV2H_PA 10 > +#define SD_GPIO(port, pin) RZG2L_GPIO(RZV2H_P##port, pin) > +#define SD_PORT_PINMUX(b, p, f) RZG2L_PORT_PINMUX(RZV2H_P##b, p, f) > + > +#include "rzv2-evk-cn15-sd-common.dtsi" These two generate the exact same .dtbo as for RZ/V2N. > diff --git a/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk.dts b/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk.dts > index 01b2e0c7c7db..219347d73753 100644 > --- a/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk.dts > +++ b/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk.dts > @@ -25,6 +25,7 @@ aliases { > i2c6 = &i2c6; > i2c7 = &i2c7; > i2c8 = &i2c8; > + mmc0 = &sdhi0; Please move to the (common) .dtso in patch 1. > mmc1 = &sdhi1; > serial0 = &scif; > }; The rest LGTM. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds