Hi Krzysztof, Thank you for the review. On Tue, Jun 17, 2025 at 8:15 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > On 17/06/2025 09:13, Krzysztof Kozlowski wrote: > > On Fri, Jun 13, 2025 at 12:38:36PM GMT, Prabhakar wrote: > >> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > >> > >> Document support for the I2C Bus Interface (RIIC) found on the Renesas > >> RZ/N2H (R9A09G087) SoC. The RIIC IP on this SoC is identical to that on > >> the RZ/T2H SoC so `renesas,riic-r9a09g077` will be used as a fallback > >> compatible. > >> > >> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > >> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > >> Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > >> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > >> --- > >> Documentation/devicetree/bindings/i2c/renesas,riic.yaml | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml > >> index 86d79e167547..6876eade431b 100644 > >> --- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml > >> +++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml > >> @@ -33,6 +33,10 @@ properties: > >> - renesas,riic-r9a09g057 # RZ/V2H(P) > >> - renesas,riic-r9a09g077 # RZ/T2H > >> > >> + - items: > >> + - const: renesas,riic-r9a09g087 # RZ/N2H > >> + - const: renesas,riic-r9a09g077 # RZ/T2H > > > > Where is an entry renesas,riic-r9a09g077 alone? Please add complete > > bindings, not half-patch and then next time second half. > > > Ah, sorry, I saw it in patch #2 (the tooling I use jumped straight to > patch #3 so that's the reason). > > Anyway, this should be squashed with #2, because it is trivial and > entire 4 lines of commit msg plus 3 reviews is really too much for > something like that. Don't inflate work for us. > Sure, I'll make a note of it and send a new version with this patch squashed. Cheers, Prabhakar
