Hi Niklas,
Thank you for the patch.
On Fri, Jun 06, 2025 at 08:26:06PM +0200, Niklas Söderlund wrote:
> With Gen2 converted to use the common media device there is only one
> caller left for the helper to notify a video device of an event, fold it
> in.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> ---
> * Changes since v4
> - Broken out from larger patch.
> ---
> .../platform/renesas/rcar-vin/rcar-v4l2.c | 20 +++++++------------
> 1 file changed, 7 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c b/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c
> index 2bf94bd77c24..59b01cb0628a 100644
> --- a/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c
> +++ b/drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c
> @@ -656,18 +656,6 @@ void rvin_v4l2_unregister(struct rvin_dev *vin)
> video_unregister_device(&vin->vdev);
> }
>
> -static void rvin_notify_video_device(struct rvin_dev *vin,
> - unsigned int notification, void *arg)
> -{
> - switch (notification) {
> - case V4L2_DEVICE_NOTIFY_EVENT:
> - v4l2_event_queue(&vin->vdev, arg);
> - break;
> - default:
> - break;
> - }
> -}
> -
> static void rvin_notify(struct v4l2_subdev *sd,
> unsigned int notification, void *arg)
> {
> @@ -693,7 +681,13 @@ static void rvin_notify(struct v4l2_subdev *sd,
> if (remote != sd)
> continue;
>
> - rvin_notify_video_device(vin, notification, arg);
> + switch (notification) {
> + case V4L2_DEVICE_NOTIFY_EVENT:
> + v4l2_event_queue(&vin->vdev, arg);
> + break;
> + default:
> + break;
> + }
How about
if (notification == V4L2_DEVICE_NOTIFY_EVENT)
v4l2_event_queue(&vin->vdev, arg);
Unless you expect more notifications to be handled later ?
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> }
> }
>
--
Regards,
Laurent Pinchart
