Hi Niklas,
Thank you for the patch.
On Fri, Jun 06, 2025 at 08:26:02PM +0200, Niklas Söderlund wrote:
> Prepare for Gen2 media graph support by always initializing a media pad
> for the VIN device.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx>
> ---
> * Changes since v4
> - New in v5, broken out from a larger patch in v4.
> ---
> drivers/media/platform/renesas/rcar-vin/rcar-core.c | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/media/platform/renesas/rcar-vin/rcar-core.c b/drivers/media/platform/renesas/rcar-vin/rcar-core.c
> index c5510e3b258f..8cb3d0a3520f 100644
> --- a/drivers/media/platform/renesas/rcar-vin/rcar-core.c
> +++ b/drivers/media/platform/renesas/rcar-vin/rcar-core.c
> @@ -895,10 +895,6 @@ static int rvin_csi2_init(struct rvin_dev *vin)
> {
> int ret;
>
> - vin->pad.flags = MEDIA_PAD_FL_SINK;
> - ret = media_entity_pads_init(&vin->vdev.entity, 1, &vin->pad);
> - if (ret)
> - return ret;
>
> ret = rvin_create_controls(vin, NULL);
> if (ret < 0)
> @@ -980,10 +976,6 @@ static int rvin_isp_init(struct rvin_dev *vin)
> {
> int ret;
>
> - vin->pad.flags = MEDIA_PAD_FL_SINK;
> - ret = media_entity_pads_init(&vin->vdev.entity, 1, &vin->pad);
> - if (ret)
> - return ret;
>
> ret = rvin_create_controls(vin, NULL);
> if (ret < 0)
> @@ -1375,6 +1367,11 @@ static int rcar_vin_probe(struct platform_device *pdev)
> if (rvin_id_get(vin))
> return -EINVAL;
>
> + vin->pad.flags = MEDIA_PAD_FL_SINK;
> + ret = media_entity_pads_init(&vin->vdev.entity, 1, &vin->pad);
> + if (ret)
> + return ret;
> +
> if (vin->info->use_isp) {
> ret = rvin_isp_init(vin);
> } else if (vin->info->use_mc) {
--
Regards,
Laurent Pinchart
