Hi Geert,
Thank you for the review.
On Fri, May 23, 2025 at 9:13 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> On Thu, 15 May 2025 at 20:31, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Enable USB2.0 support on the RZ/V2H EVK board, CN3 supports
> > host only operation and CN2 supports host/function operation.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk.dts
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g057h44-rzv2h-evk.dts
>
> > @@ -303,6 +326,28 @@ sd1_cd {
> > pinmux = <RZV2H_PORT_PINMUX(9, 4, 14)>; /* SD1_CD */
> > };
> > };
> > +
> > + usb20_pins: usb20 {
> > + vbus {
> > + pinmux = <RZV2H_PORT_PINMUX(9, 5, 14)>; /* VBUS */
> > + };
> > +
> > + ovc {
>
> Moving up to preserve sort order.
>
Thank you for taking care of this (and below).
Cheers,
Prabhakar
> > + pinmux = <RZV2H_PORT_PINMUX(9, 6, 14)>; /* OVC */
> > + bias-pull-up;
> > + };
> > + };
> > +
> > + usb21_pins: usb21 {
> > + vbus {
> > + pinmux = <RZV2H_PORT_PINMUX(6, 6, 14)>; /* VBUS */
> > + };
> > +
> > + ovc {
>
> Moving up to preserve sort order.
>
> > + pinmux = <RZV2H_PORT_PINMUX(6, 7, 14)>; /* OVC */
> > + bias-pull-up;
> > + };
> > + };
> > };
> >
> > &qextal_clk {
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> i.e. will queue in renesas-devel for v6.17 with the above fixed.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
