On Tue, Sep 09, 2025 at 09:00:09PM +0800, Chukun Pan wrote:
> Hi,
>
> > +&pcie {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pciem1_pins>, <&pcie_reset_g>;
>
> The pciem1_pins contains PCIE20_PERSTn_M1 (GPIO1_A2)
> This will cause conflicts, "pinctrl-0 = <&pciem1_pins>" is enough.
>
> [ 0.115608] rockchip-pinctrl pinctrl: not freeing pin 34 (gpio1-2) as part of deactivating group pciem1-pins - it is already used for some other setting
> [ 0.191042] rockchip-pinctrl pinctrl: pin gpio1-2 already requeste by pll_gpll; cannot claim for 140000000.pcie
> [ 0.191949] rockchip-pinctrl pinctrl: error -EINVAL: pin-34 (140000000.pcie)
> [ 0.192570] rockchip-pinctrl pinctrl: error -EINVAL: could not request pin 34 (gpio1-2) from group pciem1-pins on device rockchip-pinctrl
>
> > + reset-gpios = <&gpio1 RK_PA2 GPIO_ACTIVE_HIGH>;
>
> Missing supply: "vpcie3v3-supply = <&vcc_3v3>;"
>
> > + status = "okay";
> > +};
> > +
Will fix them in v2, thanks.
> Thanks,
> Chukun
Best regards,
Yao Zi
