On Mon, May 19, 2025 at 01:01:46AM GMT, Shradha Todi wrote:
> -static const struct dw_pcie_ops dw_pcie_ops = {
> +static const struct dw_pcie_ops exynos_dw_pcie_ops = {
> .read_dbi = exynos_pcie_read_dbi,
> .write_dbi = exynos_pcie_write_dbi,
> .link_up = exynos_pcie_link_up,
> @@ -279,6 +286,7 @@ static int exynos_pcie_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct exynos_pcie *ep;
> + const struct samsung_pcie_pdata *pdata;
> struct device_node *np = dev->of_node;
> int ret;
>
> @@ -286,8 +294,11 @@ static int exynos_pcie_probe(struct platform_device *pdev)
> if (!ep)
> return -ENOMEM;
>
> + pdata = of_device_get_match_data(dev);
> +
> + ep->pdata = pdata;
> ep->pci.dev = dev;
> - ep->pci.ops = &dw_pcie_ops;
> + ep->pci.ops = pdata->dwc_ops;
>
> ep->phy = devm_of_phy_get(dev, np, NULL);
> if (IS_ERR(ep->phy))
> @@ -363,9 +374,9 @@ static int exynos_pcie_resume_noirq(struct device *dev)
> return ret;
>
> /* exynos_pcie_host_init controls ep->phy */
> - exynos_pcie_host_init(pp);
> + ep->pdata->host_ops->init(pp);
> dw_pcie_setup_rc(pp);
> - exynos_pcie_start_link(pci);
> + ep->pdata->dwc_ops->start_link(pci);
One more layer of indirection.
Read:
https://lore.kernel.org/all/CAL_JsqJgaeOcnUzw+rUF2yO4hQYCdZYssjxHzrDvvHGJimrASA@xxxxxxxxxxxxxx/
Best regards,
Krzysztof
