Re: [PATCH v2] can: ucan: Use two USB endpoint API functions rather than duplicating their implementations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Markus Elfring <Markus.Elfring@xxxxxx>
Subject: Re: [PATCH v2] can: ucan: Use two USB endpoint API functions rather than duplicating their implementations
From: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
Date: Thu, 26 Jun 2025 23:50:40 +0900
Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, Chen Ni <nichen@xxxxxxxxxxx>, linux-can@xxxxxxxxxxxxxxx, Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
In-reply-to: <e70a929f-a5c5-487e-9231-61b5423115db@web.de>
References: <48e217a7-b90e-4af3-b535-812c449dd3ba@web.de> <bf5442d1-34e0-495f-8a56-4e47f53ca4ad@wanadoo.fr> <a7a00125-b393-4283-a7dc-6c80ced8e7e6@web.de> <c96a5d2c-0ee1-4e3e-a95d-d38a8f668feb@wanadoo.fr> <0768a008-d4a9-41ec-bc47-1e7c63362296@web.de> <c04376f2-6ab7-4256-8bdc-aa6ff3ea88b4@wanadoo.fr> <7e6f8929-6665-45af-b01b-167a1aa80305@web.de> <CAMZ6Rq+PEZWzxNYDODq-Rz_Y8T_XEihyZKoY-MYo6bn5ATaGLQ@mail.gmail.com> <1e64bcef-33f1-4295-b91f-d4598b32b866@web.de> <57815326-740d-4053-8b85-c5e57d7cec90@wanadoo.fr> <e70a929f-a5c5-487e-9231-61b5423115db@web.de>
User-agent: Mozilla Thunderbird

Hi Markus,

Thanks for the v2.

On 26/06/2025 at 23:46, Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Thu, 26 Jun 2025 16:34:26 +0200
> 
> * Reuse existing functionality from usb_endpoint_is_bulk_in()
>   and usb_endpoint_is_bulk_out() instead of keeping duplicate source code.
> 
> * Omit two comment lines which became redundant with this refactoring.
> 
> The source code was transformed by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>

Reviewed-by: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>


Yours sincerely,
Vincent Mailhol

References:
- [PATCH] can: ucan: Use usb_endpoint_type() rather than duplicating its implementation
  - From: Markus Elfring
- Re: [PATCH] can: ucan: Use usb_endpoint_type() rather than duplicating its implementation
  - From: Vincent Mailhol
- Re: can: ucan: Use usb_endpoint_type() rather than duplicating its implementation
  - From: Markus Elfring
- Re: can: ucan: Use usb_endpoint_type() rather than duplicating its implementation
  - From: Vincent Mailhol
- Re: [PATCH] can: ucan: Use usb_endpoint_type() rather than duplicating its implementation
  - From: Markus Elfring
- Re: [PATCH] can: ucan: Use usb_endpoint_type() rather than duplicating its implementation
  - From: Vincent Mailhol
- Re: can: ucan: Use usb_endpoint_type() rather than duplicating its implementation
  - From: Markus Elfring
- Re: can: ucan: Use usb_endpoint_type() rather than duplicating its implementation
  - From: Vincent Mailhol
- Re: can: ucan: Use usb_endpoint_type() rather than duplicating its implementation
  - From: Markus Elfring
- Re: can: ucan: Use usb_endpoint_type() rather than duplicating its implementation
  - From: Vincent Mailhol
- [PATCH v2] can: ucan: Use two USB endpoint API functions rather than duplicating their implementations
  - From: Markus Elfring

Prev by Date: Re: [PATCH v2] drm/i915/selftests: Change mock_request() to return error pointers
Next by Date: Re: [PATCH v2] can: ucan: Use two USB endpoint API functions rather than duplicating their implementations
Previous by thread: [PATCH v2] can: ucan: Use two USB endpoint API functions rather than duplicating their implementations
Next by thread: Re: [PATCH v2] can: ucan: Use two USB endpoint API functions rather than duplicating their implementations
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Development] [Kernel Announce] [Kernel Newbies] [Linux Networking Development] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Yosemite News] [MIPS Linux] [ARM Linux] [Device Mapper]