Re: can: ucan: Use usb_endpoint_type() rather than duplicating its implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 25/06/2025 at 03:28, Markus Elfring wrote:
>> Looking at the helpers in linux/usb/ch9.h,
> 
> Please take another look at known source code mappings.
> 
> Passing code replacements by APIs (for SmPL)?
> https://lore.kernel.org/cocci/481faa1d-7171-4657-8dc0-c37b153e6eaa@xxxxxx/
> https://sympa.inria.fr/sympa/arc/cocci/2025-06/msg00044.html
> 
> 
>> it seems that Coccinelle missed many simplifications.
> 
> Would such software transformations become better supported anyhow?

Maybe?

I am not involved in the development of Coccinelle and thus, I don't have an
answer. Nor do I have the time to read and understand the Coccinelle source code
to which you pointed me to.

My stance is that such static analyzers should never be trusted 100%. The output
is more an indicator. And in this present case, a quick review made it very
clear that Coccinelle saw one simplification but missed two other ones.


Yours sincerely,
Vincent Mailhol





[Index of Archives]     [Kernel Development]     [Kernel Announce]     [Kernel Newbies]     [Linux Networking Development]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Device Mapper]

  Powered by Linux