On Tue, Sep 2, 2025 at 7:44 AM Miklos Szeredi <mszeredi@xxxxxxxxxx> wrote:
>
> Remove tail calls of fuse_copy_finish(), since it's now done from
> fuse_dev_do_write().
>
> No functional change.
>
> Signed-off-by: Miklos Szeredi <mszeredi@xxxxxxxxxx>
Reviewed-by: Joanne Koong <joannelkoong@xxxxxxxxx>
> ---
> fs/fuse/dev.c | 79 +++++++++++++++------------------------------------
> 1 file changed, 23 insertions(+), 56 deletions(-)
>
> diff --git a/fs/fuse/dev.c b/fs/fuse/dev.c
> index 85d05a5e40e9..1258acee9704 100644
> --- a/fs/fuse/dev.c
> +++ b/fs/fuse/dev.c
> @@ -1622,35 +1622,31 @@ static int fuse_notify_poll(struct fuse_conn *fc, unsigned int size,
> struct fuse_copy_state *cs)
> {
> struct fuse_notify_poll_wakeup_out outarg;
> - int err = -EINVAL;
> + int err;
>
> if (size != sizeof(outarg))
> - goto err;
> + return -EINVAL;
>
> err = fuse_copy_one(cs, &outarg, sizeof(outarg));
> if (err)
> - goto err;
> + return err;
>
> fuse_copy_finish(cs);
Maybe worth also removing fuse_copy_finish() here (and for the other
notify handlers) since it's going to get called anyways?
Thanks,
Joanne
> return fuse_notify_poll_wakeup(fc, &outarg);
> -
