Re: [PATCH 3/4] fuse: remove redundant calls to fuse_copy_finish() in fuse_notify()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 3 Sept 2025 at 12:26, Luis Henriques <luis@xxxxxxxxxx> wrote:

> I wonder if these extra fuse_copy_finish() calls should also be removed.
> It doesn't seem to be a problem to call it twice, but maybe it's not
> needed, or am I missing something?  This happens in a few places.

It's not a clear no-op, since the put_page() for the userspace buffer
is being moved to after processing the notification.

I don't think this should cause problems, but it's something that I
wouldn't like to do without a bit of thought.

Thanks,
Miklos




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [NTFS 3]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [NTFS 3]     [Samba]     [Device Mapper]     [CEPH Development]

  Powered by Linux