Re: [PATCH RFC 2/3] mke2fs.c: fail on multiple '-E' options

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Sep 09, 2025 at 08:49:37PM -0400, Ralph Siemsen wrote:
> Hi Andreas,
> 
> On Tue, Sep 9, 2025 at 8:32 PM Andreas Dilger <adilger@xxxxxxxxx> wrote:
> >
> > I think it would be much better to allow and merge multiple "-E" options.
> 
> Agreed. I'll work on it and post a v2 patch.

What I would suggest that you do is to move code which mutates the
file system from parse_extended_opts() so it is only interpreting the
options, and move that code to tuine2fs_main().

That way we can call parse_extended_opts() multiple times.  In fact,
that had been on my todo list, since I need to do this to support
changing the superblock using ioctl's while it is mounted, so we can
deny read/write access to the block device while the file system is
mounted.  See [1].

[1] https://lore.kernel.org/all/20250908-tune2fs-v1-0-e3a6929f3355@xxxxxxx/

Cheers,

						- Ted




[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux