Hi Ted, On Wed, Sep 10, 2025 at 10:52 AM Theodore Ts'o <tytso@xxxxxxx> wrote: > What I would suggest that you do is to move code which mutates the > file system from parse_extended_opts() so it is only interpreting the > options, and move that code to tuine2fs_main(). Yes, I see where you are going. Being able to deny read/write to a block device that is mounted is a good goal. But I am talking about mke2fs rather than tune2fs. I can't really see a need for two code paths when creating a filesystem? It would still make sense to separate the option parsing from the mutation logic of course. > That way we can call parse_extended_opts() multiple times. Note this is already occurs in mke2fs: one call to process options from profile/config file, and another call for command-line args. So in v2 patch, I just made further calls, one for each -E argument. So far it seems to work without problems. Regards -Ralph
