Re: [PATCH net-next 01/15] devlink: add value check to devlink_info_version_put()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Unrelated (I think?) this is a relatively big series so I don't want
to race with it, but I think we should rename the defines.

you are right that this is unrelated but conflicting :)


DEVLINK_INFO_VERSION_GENERIC_x -> DEVLINK_VER_x ?

You did some major devlink refactors, maybe you want to take this on? :)
The 40 char defines lead to pretty ugly wrapping, and make constructs
like:

	if (something)
		devlink_info_version_running_put(...

impossible. We could also rename the helpers to s/_version// ..

sure, I have also one more refactor idea around this family of functions
so it would fit well :)




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux