On 09/04/2025 18:25, Nelson, Shannon wrote: > On 4/9/2025 7:39 AM, Jakub Kicinski wrote: >> >> On Wed, 9 Apr 2025 14:14:23 +0000 Jagielski, Jedrzej wrote: >>> No insisting on that but should empty entry be really presented to the user? >>> Especially unintentionally? Actually it's exposing some driver's shortcomings. >>> That means the output was not properly validated so imho there's no point in >>> printing it. >> >> +1, FWIW, I don't see the point of outputting keys without values. > > Because I like to see hints that something might be wrong, rather than hiding them. +1 to this. Failures should be noisy. Time you care most about these data is when something *is* wrong and you're trying to debug it. AFAICT the argument on the other side is "it makes the driver look bad", which has (expletive)-all to do with engineering. Value often comes from firmware, anyway, in which case driver's (& core's) job is to be a dumb pipe, not go around 'validating' things.
