From: Nelson, Shannon <shannon.nelson@xxxxxxx> Sent: Tuesday, April 8, 2025 2:31 AM >On 4/7/2025 2:51 PM, Tony Nguyen wrote: >> From: Jedrzej Jagielski <jedrzej.jagielski@xxxxxxxxx> >> >> Prevent from proceeding if there's nothing to print. >> >> Suggested-by: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx> >> Reviewed-by: Jiri Pirko <jiri@xxxxxxxxxx> >> Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@xxxxxxxxxxxx> >> Tested-by: Bharath R <bharath.r@xxxxxxxxx> >> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@xxxxxxxxx> >> Signed-off-by: Tony Nguyen <anthony.l.nguyen@xxxxxxxxx> >> --- >> net/devlink/dev.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/devlink/dev.c b/net/devlink/dev.c >> index d6e3db300acb..02602704bdea 100644 >> --- a/net/devlink/dev.c >> +++ b/net/devlink/dev.c >> @@ -775,7 +775,7 @@ static int devlink_info_version_put(struct devlink_info_req *req, int attr, >> req->version_cb(version_name, version_type, >> req->version_cb_priv); >> >> - if (!req->msg) >> + if (!req->msg || !*version_value) > >Personally, I'd like to know that the value was blank if there was >normally a value to be printed. This is removing a useful indicator of >something that might be wrong. > >sln Actually this still works the same - when there is no entry that means that the input was blank, so it still gives you some message.
