Eric Sunshine <sunshine@xxxxxxxxxxxxxx> writes: > On Mon, Jun 2, 2025 at 5:58 AM Karthik Nayak <karthik.188@xxxxxxxxx> wrote: >> Since expressions don't expand within single quotes, change test >> descriptions containing variables to use double quotes. >> >> Signed-off-by: Karthik Nayak <karthik.188@xxxxxxxxx> >> --- >> diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh >> @@ -1421,7 +1421,7 @@ test_expect_success 'peeled advertisements are not considered ref tips' ' >> -test_expect_success 'pushing a specific ref applies remote.$name.push as refmap' ' >> +test_expect_success "pushing a specific ref applies remote.$name.push as refmap" ' > > If I'm understanding correctly, I think this and the other changes in > this patch are incorrect. There is no `name` variable in this script. > Rather, these "$name" instances are merely illustrative, acting as > placeholders for the person reading the test title. Huh, you're absolutely right. I think I did a 'grep -v' to ensure it worked and failed to realize that my shell was replacing $name. Will skip this patch in the follow up. Thanks!
Attachment:
signature.asc
Description: PGP signature
