Re: [PATCH 2/3] t5516: use double quotes for tests with variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 2, 2025 at 5:58 AM Karthik Nayak <karthik.188@xxxxxxxxx> wrote:
> Since expressions don't expand within single quotes, change test
> descriptions containing variables to use double quotes.
>
> Signed-off-by: Karthik Nayak <karthik.188@xxxxxxxxx>
> ---
> diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh
> @@ -1421,7 +1421,7 @@ test_expect_success 'peeled advertisements are not considered ref tips' '
> -test_expect_success 'pushing a specific ref applies remote.$name.push as refmap' '
> +test_expect_success "pushing a specific ref applies remote.$name.push as refmap" '

If I'm understanding correctly, I think this and the other changes in
this patch are incorrect. There is no `name` variable in this script.
Rather, these "$name" instances are merely illustrative, acting as
placeholders for the person reading the test title.





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux