Re: [PATCH v4 1/2] pack-bitmap: fix memory leak if load_bitmap() failed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Got it, I will add my sign-off.

> 2025年5月29日 23:33,Junio C Hamano <gitster@xxxxxxxxx> 写道:
> 
> "Taylor Blau via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
> 
>> From: Taylor Blau <me@xxxxxxxxxxxx>
>> 
>> After going through the "failed" label, load_bitmap() will return -1,
>> and its caller (either prepare_bitmap_walk() or prepare_bitmap_git())
>> will then call free_bitmap_index().
>> ...
>> The solution is to remove the error handling code in load_bitmap(), because
>> its caller will always call free_bitmap_index() in case of an error.
>> 
>> Signed-off-by: Taylor Blau <me@xxxxxxxxxxxx>
>> ---
> 
> As this is Lidong relaying <aCOFqYdnPp1Lne4Y@nand.local> that Taylor
> sent to the list, shouldn't Lidong's sign-off be after Taylor's?
> 






[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux