"Taylor Blau via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > From: Taylor Blau <me@xxxxxxxxxxxx> > > After going through the "failed" label, load_bitmap() will return -1, > and its caller (either prepare_bitmap_walk() or prepare_bitmap_git()) > will then call free_bitmap_index(). > ... > The solution is to remove the error handling code in load_bitmap(), because > its caller will always call free_bitmap_index() in case of an error. > > Signed-off-by: Taylor Blau <me@xxxxxxxxxxxx> > --- As this is Lidong relaying <aCOFqYdnPp1Lne4Y@nand.local> that Taylor sent to the list, shouldn't Lidong's sign-off be after Taylor's?