https://bugzilla.redhat.com/show_bug.cgi?id=2371047 Tomi Lähteenmäki <lihis@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(benson_muite@emai | |lplus.org) --- Comment #3 from Tomi Lähteenmäki <lihis@xxxxxxxxx> --- Went through of the spec, here is some comments before doing the full review: - Is the static library really needed? If not, remove it in %install (so no -static package). - Would the library be useful for others? I.e. would it make sense to package the library into "libsonic" package and "sonic" package Requires it? - Personally I would do string substitution on the "shortcommit": > %global shortcommit %{sub %{commit} 1 7} - Preemptively consider Epoch: > Requires: %{name}%{?_isa} = %{?epoch:%{epoch}:}%{version}-%{release} - There is one extra line break before %install and %changelog, consider removing the extra line breaks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2371047 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202371047%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
