https://bugzilla.redhat.com/show_bug.cgi?id=2371047 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(benson_muite@emai | |lplus.org) | --- Comment #4 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Thanks for your feedback. spec: https://fed500.fedorapeople.org/sonic.spec srpm: https://fed500.fedorapeople.org/sonic-0.2.0^20210316gitba33141-1.fc42.src.rpm (In reply to Tomi Lähteenmäki from comment #3) > Went through of the spec, here is some comments before doing the full review: > > - Is the static library really needed? If not, remove it in %install (so no > -static package). Done. > > - Would the library be useful for others? I.e. would it make sense to > package the library into "libsonic" package and "sonic" package Requires it? > Done. > - Personally I would do string substitution on the "shortcommit": > > > %global shortcommit %{sub %{commit} 1 7} > Done. > - Preemptively consider Epoch: > > > Requires: %{name}%{?_isa} = %{?epoch:%{epoch}:}%{version}-%{release} > Left as is for now. > - There is one extra line break before %install and %changelog, consider > removing the extra line breaks Done. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2371047 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202371047%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
