https://bugzilla.redhat.com/show_bug.cgi?id=2363932 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #7 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- (In reply to Charles R. Anderson from comment #3) > (In reply to Jitka Plesnikova from comment #2) > > FIX: Add build-require 'coreutils' it is needed for %{_fixperms} > > FIX: Please add build-requires > > - perl(Config) - t/40-autodetect-executable.t:8 > > TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 > > NO_PACKLIST is provided since this version. > > FIX: Add run-require > > - perl(DynaLoader) - lib/ExtUtils/Builder/ParseXS.pm:72 > > FIX: Remove duplicit run-requires: > > - perl(ExtUtils::Config) >= 0.007 > > - perl(ExtUtils::Helpers) >= 0.027 > > TODO: Explicitly name packaged files in %{_mandir}/man* and > > %{perl_vendorlib} directories > > The above items are all fixed: 8a11 + BuildRequires: coreutils 15a19 + BuildRequires: perl(Config) 26c30 - BuildRequires: perl(ExtUtils::MakeMaker) --- + BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 39,40c43 - Requires: perl(ExtUtils::Config) >= 0.007 - Requires: perl(ExtUtils::Helpers) >= 0.027 --- + Requires: perl(DynaLoader) 66,67c69,71 - %{perl_vendorlib}/* - %{_mandir}/man3/* --- + %dir %{perl_vendorlib}/ExtUtils + %{perl_vendorlib}/ExtUtils/Builder + %{_mandir}/man3/ExtUtils::Builder* The changes look good. Resolution: Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2363932 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202363932%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
