https://bugzilla.redhat.com/show_bug.cgi?id=2363933 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #5 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- (In reply to Charles R. Anderson from comment #3) > (In reply to Jitka Plesnikova from comment #2) > > FIX: Add build-require 'coreutils' it is needed for %{_fixperms} > > FIX: Add build-require > > - perl(Config) - t/simple.t:4 > > FIX: Please add run-requires: > > perl(CPAN::Meta::Merge) - lib/Dist/Build.pm:134 > > perl(CPAN::Requirements::Dynamic) - lib/Dist/Build/DynamicPrereqs.pm:17 > > perl(Perl::OSType) - lib/Dist/Build.pm:93 > > perl(Pod::Man) - lib/Dist/Build/Core.pm:309 > > perl(TAP::Harness::Env) - lib/Dist/Build/Core.pm:332 > > FIX: Please remove duplicit run-requires: > > perl(Exporter) >= 5.57 > > perl(ExtUtils::Builder::Planner) >= 0.016 > > perl(ExtUtils::Helpers) >= 0.028 > > perl(Getopt::Long) >= 2.36 > > perl(List::Util) >= 1.33 > > TODO: Explicitly name packaged files in %{_mandir}/man* and > > %{perl_vendorlib} directories > > I fixed all the above issues: 10a11 + BuildRequires: coreutils 17a19 + BuildRequires: perl(Config) 64a67 + Requires: perl(CPAN::Meta::Merge) 66d68 - Requires: perl(Exporter) >= 5.57 68,71c70,72 - Requires: perl(ExtUtils::Builder::Planner) >= 0.016 - Requires: perl(ExtUtils::Helpers) >= 0.028 - Requires: perl(Getopt::Long) >= 2.36 - Requires: perl(List::Util) >= 1.33 --- + Requires: perl(Perl::OSType) + Requires: perl(Pod::Man) + Requires: perl(TAP::Harness::Env) 98,99c99,102 - %{perl_vendorlib}/* - %{_mandir}/man3/* --- + %dir %{perl_vendorlib}/Dist + %{perl_vendorlib}/Dist/Build.pm + %{perl_vendorlib}/Dist/Build + %{_mandir}/man3/Dist::Build* The changes look good. Resolution: Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2363933 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202363933%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
