https://bugzilla.redhat.com/show_bug.cgi?id=2388375 --- Comment #50 from Cristian Le <fedora@xxxxxxxxx> --- Only have 3 more comments: > Copr builds succeed. The only recurring note is the known “Upstream MD5sum check error” with GitHub auto-generated tarballs, which is a false positive per Fedora packaging guidelines discussion around SourceURL/tarball reproducibility. This does not apply here, it is a genuine issue, I just haven't looked into what exactly causes the difference in your case. If you want to make sure it is clean, build the srpm from mock, various ways of doing so ``` $ fbrnch srpm $ mock --buildsrpm $ fedpkg srpm --srpm-mock ``` Some of these also do the download which would make sure the Source0 is also consistent. > – I kept the build-time dependencies minimal and treated GI/GTK as runtime deps. If you prefer further trimming (e.g., dropping gtk3-devel if superfluous on your side), I’m happy to adjust immediately. (Non-blocking) Reducing build-time dependencies is important. We have automations like Koschei and manual rebuilds whenever a dependency is updated. Reducing the dependencies reduces the maintenance overhead of other packagers if the project becomes FTBFS. --- I have tried to run this locally in a clean container and there are missing runtime dependencies. These are not detected automatically because they are not linked at build-time, instead they are loaded dynamically by the python modules. You need to add these dependencies as runtime dependencies, as manual `Requires` is acceptable. Upstream documented these to be `python3-cairo`, `python3-gobject` which do not seem to have PyPI counterparts which I guess is why these are not added to the `setup.py`. I did try to install those in the container, but it still didn't run, but I don't know if it is due to it being in a container. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2388375 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202388375%23c50 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
