[Bug 2363088] Review Request: ocaml-camlpdf - OCaml library for reading, writing, and modifying PDFs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2363088

Jerry James <loganjerry@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?
                 CC|                            |loganjerry@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |loganjerry@xxxxxxxxx
             Status|NEW                         |ASSIGNED



--- Comment #13 from Jerry James <loganjerry@xxxxxxxxx> ---
I will take this review.

(In reply to John Whitington from comment #5)
> (Sidenote: I copied the %global debug_package %{nil} from here
> https://docs.fedoraproject.org/en-US/packaging-guidelines/OCaml/ so if
> that's wrong, it wants updating...)

Note that every instance of %global debug_package %{nil} in the guidelines
looks like this:

%ifnarch %{ocaml_native_compiler}
%global debug_package %{nil}
%endif

That is, it applies only to bytecode-only architectures.  OCaml packages
without any C bindings do not create any ELF objects, so there is nothing to
strip debuginfo out of.  OCaml packages with C bindings should not use this, as
there will still be a shared object that contains debuginfo even on
bytecode-only architectures.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2363088

Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202363088%23c13

-- 
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux