https://bugzilla.redhat.com/show_bug.cgi?id=2387789 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ CC| |ppisar@xxxxxxxxxx Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |ppisar@xxxxxxxxxx --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- URL and Source0 addresses are Ok. Source0 archive (SHA-512: e1182ecc2647ae207b07042ec9b286779c3eef42b8e7c6da6e1c73b454b2782a9b89f33d78dc8f2b469ac8029b2e8b5fc79f12a1e90ce77467d3e3cfac207ad2) is original. Ok. Summary and description verified from lib/Crypt/SysRandom/XS.pm. OK. License verified from lib/Crypt/SysRandom/XS.pm, LICENSE, and README. Ok. XS code is present, no noarch BuildArch is Ok. FIX: Build-require `findutils' (perl-Crypt-SysRandom-XS.spec:40). TODO: Do not package `planner' as documentation. It's a script executed by Build.PL. XXX: This module does not do what it documents: It promises "cryptographically random data", but it calls getrandom(,,0) which means reading from urandom which is not cryptographically resilient. The syscall should be called with GRND_RANDOM flag. System-wide build flags are respected. Ok. $ rpmlint perl-Crypt-SysRandom-XS.spec ../SRPMS/perl-Crypt-SysRandom-XS-0.009-1.fc44.src.rpm ../RPMS/x86_64/perl-Crypt-SysRandom-XS-* ======================================== rpmlint session starts ======================================= rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 perl-Crypt-SysRandom-XS.x86_64: E: spelling-error ('cryptographically', '%description -l en_US cryptographically -> photographically, typographically, topographically') perl-Crypt-SysRandom-XS.src: E: spelling-error ('cryptographically', '%description -l en_US cryptographically -> photographically, typographically, topographically') perl-Crypt-SysRandom-XS.x86_64: E: incorrect-fsf-address /usr/share/licenses/perl-Crypt-SysRandom-XS/LICENSE == 4 packages and 1 specfiles checked; 3 errors, 0 warnings, 13 filtered, 3 badness; has taken 0.6 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-Crypt-SysRandom-XS-0.009-1.fc44.x86_64.rpm drwxr-xr-x 2 root root 0 Aug 11 02:00 /usr/lib/.build-id drwxr-xr-x 2 root root 0 Aug 11 02:00 /usr/lib/.build-id/ca lrwxrwxrwx 1 root root 69 Aug 11 02:00 /usr/lib/.build-id/ca/3059f70aeb4e75965f31f89732dd19be79c96c -> ../../../../usr/lib64/perl5/vendor_perl/auto/Crypt/SysRandom/XS/XS.so drwxr-xr-x 2 root root 0 Aug 11 02:00 /usr/lib64/perl5/vendor_perl/Crypt drwxr-xr-x 2 root root 0 Aug 11 02:00 /usr/lib64/perl5/vendor_perl/Crypt/SysRandom -rw-r--r-- 1 root root 1590 Apr 11 18:46 /usr/lib64/perl5/vendor_perl/Crypt/SysRandom/XS.pm drwxr-xr-x 2 root root 0 Aug 11 02:00 /usr/lib64/perl5/vendor_perl/auto/Crypt drwxr-xr-x 2 root root 0 Aug 11 02:00 /usr/lib64/perl5/vendor_perl/auto/Crypt/SysRandom drwxr-xr-x 2 root root 0 Aug 11 02:00 /usr/lib64/perl5/vendor_perl/auto/Crypt/SysRandom/XS -rwxr-xr-x 1 root root 11208 Aug 11 02:00 /usr/lib64/perl5/vendor_perl/auto/Crypt/SysRandom/XS/XS.so drwxr-xr-x 2 root root 0 Aug 11 02:00 /usr/share/doc/perl-Crypt-SysRandom-XS -rw-r--r-- 1 root root 1054 Apr 11 18:46 /usr/share/doc/perl-Crypt-SysRandom-XS/Changes -rw-r--r-- 1 root root 390 Apr 11 18:46 /usr/share/doc/perl-Crypt-SysRandom-XS/README -rw-r--r-- 1 root root 3753 Apr 11 18:46 /usr/share/doc/perl-Crypt-SysRandom-XS/SECURITY.md drwxr-xr-x 2 root root 0 Apr 11 18:46 /usr/share/doc/perl-Crypt-SysRandom-XS/planner -rw-r--r-- 1 root root 2476 Apr 11 18:46 /usr/share/doc/perl-Crypt-SysRandom-XS/planner/xs.pl drwxr-xr-x 2 root root 0 Aug 11 02:00 /usr/share/licenses/perl-Crypt-SysRandom-XS -rw-r--r-- 1 root root 19744 Apr 11 18:46 /usr/share/licenses/perl-Crypt-SysRandom-XS/LICENSE -rw-r--r-- 1 root root 1510 Aug 11 02:00 /usr/share/man/man3/Crypt::SysRandom::XS.3pm.gz File layout and permissions are Ok. TODO: Remove the planner. $ rpm -q --requires -p ../RPMS/x86_64/perl-Crypt-SysRandom-XS-0.009-1.fc44.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.11)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.25)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libc.so.6(GLIBC_ABI_DT_RELR)(64bit) 1 perl(:MODULE_COMPAT_5.42.0) 1 perl(Exporter) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 perl-libs 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-Crypt-SysRandom-XS-0.009-1.fc44.x86_64.rpm | sort -f | uniq -c 1 perl(Crypt::SysRandom::XS) = 0.009 1 perl-Crypt-SysRandom-XS = 0.009-1.fc44 1 perl-Crypt-SysRandom-XS(x86-64) = 0.009-1.fc44 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-Crypt-SysRandom-XS-0.009-1.fc44.x86_64.rpm Binary dependencies are resolvable. Ok. The package builds in F44 (https://koji.fedoraproject.org/koji/taskinfo?taskID=136505770). Ok. Otherwise, the package is in line with Fedora and Perl packaging guidelines. Please correct the FIX and TODO items before building this package. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2387789 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202387789%23c2 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
