https://bugzilla.redhat.com/show_bug.cgi?id=2363088 --- Comment #14 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to John Whitington from comment #3) > 3. _smp_ncpus_max to 1. This is because OCamlMakefile breaks under -j. Does it? I've done a few builds in a row with this removed, and the build succeeded every time. What kind of breakage are you seeing? The minimal patch seems fine. As you noted, debuginfo seems to be generated correctly with that patch. I see that miniz 2.1.0 is bundled. As described in https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling, we should avoid that if possible. Note that miniz 3.0.2 is currently available from Fedora. Can you use the Fedora package instead of the bundled version? The rijndael-alg-fst.{c,h} and sha2.{c,h} files are also bundled versions of other projects. Refer to that guidelines URL for adding the correct "Provides: bundled(foo)" lines to the spec file if they cannot be unbundled. Also, if that code is to remain bundled, then the respective licenses must appear in the License field. A comment should also be added somewhere (typically right above the License field) indicating which source files each license pertains to. Please replace the Source line with this: Source: https://github.com/johnwhitington/camlpdf/archive/v%{version}/camlpdf-%{version}.tar.gz That gives us a tarball whose name contains the name of the project, and matches the name of the directory it unpacks into. Suggestion: if you add "BuildRequires: ocaml-rpm-macros", and add "%ocaml_files" to the end of %install, then you can replace the cluttered %files sections with just this: %files -f .ofiles %doc README.md %license LICENSE %files devel -f .ofiles-devel -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2363088 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202363088%23c14 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
