https://bugzilla.redhat.com/show_bug.cgi?id=2363088 --- Comment #15 from John Whitington <john@xxxxxxxxxxxxxxxxxxxxxx> --- Thanks for taking this on, Jerry. Here's the new version: https://www.coherentpdf.com/fedora/ocaml-camlpdf-attempt3.zip Build log: https://koji.fedoraproject.org/koji/taskinfo?taskID=136654470 Notes: 1. OCamlMakefile and -j It's a well-known limitation. I couldn't provoke it on Fedora today, just like you, but it fails easily on MacOS. I'm also sure it failed once on Koji, because that's why I added it - to fix a broken build. Here's an example of an existing Fedora OCaml package which disables parallel builds for OCamlMakefile, albeit in a different way: %build # Parallel builds of this package fail. unset MAKEFLAGS See: https://src.fedoraproject.org/rpms/ocaml-mysql/blob/rawhide/f/ocaml-mysql.spec 2. Bundling of Miniz We can't do this. PDF files can contain a certain kind of malformed zlib data which requires a complicated dance to support. This involves our own changes to flatestubs.c (extracted from CamlZip) but also using v2.1.0 of miniz. Later versions don't allow even our workaround to read these malformed zlib streams. Unbundling Miniz would result in a Fedora CamlPDF which could not read some PDF files. 3. Bundling of Rijndael/SHA These files (and their OCaml stubs) are tiny extracts from OCaml CryptoKit. The logical thing to do, then, might be to depend on OCaml-CryptoKit. But the Fedora ocaml-cryptokit package bundles these same Rijndael/SHA C files (amongst others) anyway, rather than relying on the packages you mention! So, it's no improvement. 4. Licenses/Provides for Miniz/Rijndael/SHA Done. 5. Source line replacement Done 6. %files simplification suggestion Done -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2363088 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202363088%23c15 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
