https://bugzilla.redhat.com/show_bug.cgi?id=2314290 --- Comment #6 from Bruno Thomsen <bruno.thomsen@xxxxxxxxx> --- It looks like CMake add_library is called with SHARED[1] and not MODULE[2] which is more correct when it's loadable modules and not shared libraries. Install TARGETS[3] allows setting where plugins are installed. Internal libraries should be built as shared libraries where possible, see rpath for internal libraries[4]. [1] https://github.com/mcallegari/qlcplus/blob/8a22b7b840a2f222ac623a88136bd45a37dfeb99/plugins/enttecwing/src/CMakeLists.txt#L23 [2] https://cmake.org/cmake/help/latest/command/add_library.html#command:add_library [3] https://cmake.org/cmake/help/book/mastering-cmake/chapter/Install.html [4] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_rpath_for_internal_libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2314290 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202314290%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
