https://bugzilla.redhat.com/show_bug.cgi?id=2314290 --- Comment #7 from Mads Kiilerich <mads@xxxxxxxxxxxxx> --- Thanks, Bruno. Yes, it seems like plugins like /usr/lib64/qt5/plugins/qlcplus/libenttecwing.so rather should use MODULE. But it seems OK that the different parts of the main program like libqlcplusengine.so are using SHARED. We might be able to give some advice to upstream, but it doesn't seem like something that has to be a blocker for packaging ... unless it cause a real blocker. FWIW, I do not see any statement that "internal libraries should be built as shared libraries where possible". I can imagine cases where it obviously would be beneficial, but in this case it wouldn't really enable any reuse and wouldn't have any benefits. But ok, no problem. Thanks for the cmake pointers. That got me started looking at stuff I haven't looked at in a while. I think I found an ok solution: I keep the 3 internal modules as SHARED but set the DESTINATIONs to %{_libdir}/qlcplus , and set INSTALL_RPATH accordingly for the 2 binaries that use them. Spec URL: https://kiilerix.fedorapeople.org/qlcplus-4.14.3-2.spec SRPM URL: https://kiilerix.fedorapeople.org/qlcplus-4.14.3-2.fc43.src.rpm Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=135084222 Description: Q Light Controller Plus Fedora Account System Username: kiilerix -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2314290 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202314290%23c7 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
