https://bugzilla.redhat.com/show_bug.cgi?id=2314290 --- Comment #5 from Mads Kiilerich <mads@xxxxxxxxxxxxx> --- Hej Bruno, thanks for the review. Sorry, I didn't notice it until I saw the new comment. I have addressed most of the comments, updated the package to latest upstream, and made other minor improvements. The only lint warnings are now where upstream genuinely uses the same small svg files in several places. The biggest topic is how upstream uses dynamic linking between its internal modules. I did not consider that a significant issue. Do you know a simple way to move these to a subdirectory using cmake and Fedora stripping rpath? I think the best solution is to just link these modules statically. That is just a simple change to the build system. With only two binaries that can be optimized while linking, the end result is a smaller package. The main disadvantage is that the unittest binaries will be statically linked too, and they add up in size ... but that doesn't seem like a big problem to me. Do you agree, or what approach do you suggest? Benson, also thanks for the comments. Note that upstream uses a non-standard tagging / release process, so your URL suggestion doesn't work. But I settled on a compromise. The forge macros seem clever, but doesn't improve legibility to me ... I also already contributed many changes upstream. Their goal is however to use obs to build cross platform packages, and not necessarily follow Fedora packaging guidelines. Spec URL: https://kiilerix.fedorapeople.org/qlcplus-4.14.3-1.spec SRPM URL: https://kiilerix.fedorapeople.org/qlcplus-4.14.3-1.fc43.src.rpm Koji scratch builds: https://koji.fedoraproject.org/koji/taskinfo?taskID=134939642 Description: Q Light Controller Plus Fedora Account System Username: kiilerix -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2314290 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202314290%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
