https://bugzilla.redhat.com/show_bug.cgi?id=2314290 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benson_muite@xxxxxxxxxxxxx --- Comment #4 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Good feedback. Helpful to explicitly indicate as many items which have been checked. Files in %{_bindir} and %{_libdir} should be explicitly listed as updates may add new files and one wants to be sure no conflicts occur. Please replace Source0: https://github.com/mcallegari/qlcplus/archive/refs/tags/QLC+_%{version}.tar.gz by Source0: https://github.com/mcallegari/qlcplus/archive/%{version}/qlcplus-%{version}.tar.gz see https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags could also use forge macros https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_using_forges_hosted_revision_control Maybe worth contributing changes upstream: https://github.com/mcallegari/qlcplus/blob/master/platforms/linux/qlcplus.spec -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2314290 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202314290%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
