https://bugzilla.redhat.com/show_bug.cgi?id=2373038 --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thank you for your comments! > 1- You might want to implement fdupes in your spec. Adding it as a BR and doing %fdupes %{buildroot} will find all the duplicate files and symlink them, lowering the file size. Why? I'm not aware of any large number of "duplicate" files in this package. Additionally, the current implementation of %fdupes is brittle and causes non-reproducible package builds, so I would rather avoid it unless it really provides big benefits. > 2- This should probably be looked into: E: incorrect-fsf-address /usr/share/licenses/elementary-photos/COPYING (At least a PR might be a good idea) Thanks, I'll report this upstream. It shouldn't be a blocker though. > 3- The following should probably be added as Requires: As far as I can tell, this is just a weird way that meson prints output when looking for dependencies. The executable in this package already dynamically links to all these libraries, so RPM already generates explicit Requires for all of them (as you can see from the build.log or the Requires in the fedora-review.txt). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2373038 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202373038%23c4 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
