https://bugzilla.redhat.com/show_bug.cgi?id=2373038 Steve Cossette <farchord@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |farchord@xxxxxxxxx --- Comment #3 from Steve Cossette <farchord@xxxxxxxxx> --- A couple preliminary comments: 1- You might want to implement fdupes in your spec. Adding it as a BR and doing %fdupes %{buildroot} will find all the duplicate files and symlink them, lowering the file size. 2- This should probably be looked into: E: incorrect-fsf-address /usr/share/licenses/elementary-photos/COPYING (At least a PR might be a good idea) 3- The following should probably be added as Requires: Run-time dependency glib-2.0 found: YES 2.85.1 Run-time dependency gio-unix-2.0 found: YES 2.85.1 Run-time dependency gee-0.8 found: YES 0.20.8 Run-time dependency gexiv2 found: YES 0.14.5 Run-time dependency geocode-glib-2.0 found: YES 3.26.4 Run-time dependency gmodule-2.0 found: YES 2.85.1 Run-time dependency gstreamer-1.0 found: YES 1.26.2 Run-time dependency gstreamer-base-1.0 found: YES 1.26.2 Run-time dependency gstreamer-plugins-base-1.0 found: YES 1.26.2 Run-time dependency gstreamer-pbutils-1.0 found: YES 1.26.2 Run-time dependency granite found: YES 6.2.0 Run-time dependency gtk+-3.0 found: YES 3.24.49 Run-time dependency gudev-1.0 found: YES 238 Run-time dependency libhandy-1 found: YES 1.8.3 Run-time dependency libexif found: YES 0.6.25 Run-time dependency libgphoto2 found: YES 2.5.31 Run-time dependency libraw found: YES 0.21.4 Run-time dependency libwebp found: YES 1.5.0 Run-time dependency libportal found: YES 0.9.1 Run-time dependency libportal-gtk3 found: YES 0.9.1 Run-time dependency sqlite3 found: YES 3.50.0 (They are added as a build requirement, but as they are runtime, they will be needed on runtime) Once that's done I can look into doing the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2373038 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202373038%23c3 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
