https://bugzilla.redhat.com/show_bug.cgi?id=2354972 --- Comment #6 from Sandro <gui1ty@xxxxxxxxxxxxx> --- I admit I totally overlooked those. However, the library itself does not depend on anything in the ThirdParty directory: # ldd libunits.so.0.13.0 linux-vdso.so.1 (0x00007f72e78fd000) libstdc++.so.6 => /lib64/libstdc++.so.6 (0x00007f72e7400000) libm.so.6 => /lib64/libm.so.6 (0x00007f72e777e000) libgcc_s.so.1 => /lib64/libgcc_s.so.1 (0x00007f72e7752000) libc.so.6 => /lib64/libc.so.6 (0x00007f72e720f000) /lib64/ld-linux-x86-64.so.2 (0x00007f72e78ff000) nor are any of the files shipped in the final RPMs. The stuff inside ThirdParty is exclusively used for the test suite. Would it be sufficient to make a note of the sources and their licenses in the spec file? That would be less hassle than having to patch the CMake configuration and the test sources. On the other hand, we do have all the required packages available in Fedora: CLI11.hpp --> cli11 json.hpp --> json xml/tinxml2.cpp --> tinyxml2 (not part of the devel package; might be modified) xml/tinyxml2.h --> tinyxml2 units-0.13.0/ThirdParty/googletest/ is a submodule stub. It has already been made configurable and I'm using the Fedora package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2354972 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202354972%23c6 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
