https://bugzilla.redhat.com/show_bug.cgi?id=2354972 --- Comment #5 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Started reviewing this now. To begin with, I noticed that the sources include a "ThirdParty" folder which bundles bits like tinyxml2. We should either make it use system libraries or update the spec to note the bundled bits. If we bundle, the license will also need to include the licenses of the bundled bits (if different from the package), since they're being linked to in the build. units-0.13.0/ThirdParty/ units-0.13.0/ThirdParty/CLI11.hpp units-0.13.0/ThirdParty/cmake/ units-0.13.0/ThirdParty/cmake/CodeCoverage.cmake units-0.13.0/ThirdParty/cmake/GitUtils.cmake units-0.13.0/ThirdParty/cmake/Utils.cmake units-0.13.0/ThirdParty/cmake/extraMacros.cmake units-0.13.0/ThirdParty/cmake/updateGitSubmodules.cmake units-0.13.0/ThirdParty/googletest/ units-0.13.0/ThirdParty/json.hpp units-0.13.0/ThirdParty/xml/ units-0.13.0/ThirdParty/xml/tinyxml2.cpp units-0.13.0/ThirdParty/xml/tinyxml2.h -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2354972 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202354972%23c5 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
