Re: [PATCH 01/23] md: add a new parameter 'offset' to md_super_write()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

在 2025/05/26 14:28, Christoph Hellwig 写道:
On Sat, May 24, 2025 at 02:12:58PM +0800, Yu Kuai wrote:
-void md_super_write(struct mddev *mddev, struct md_rdev *rdev,
-		   sector_t sector, int size, struct page *page)
+void md_write_metadata(struct mddev *mddev, struct md_rdev *rdev,
+		       sector_t sector, int size, struct page *page,
+		       unsigned int offset)

Maybe add a little command explaining what it does?

OK.

+extern void md_write_metadata(struct mddev *mddev, struct md_rdev *rdev,
+			      sector_t sector, int size, struct page *page,
+			      unsigned int offset);

No need for the extern.  Otherwise looks good:

Got it.
Thanks for the review!

Kuai


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

.






[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux