On Sat, May 24, 2025 at 02:12:58PM +0800, Yu Kuai wrote: > -void md_super_write(struct mddev *mddev, struct md_rdev *rdev, > - sector_t sector, int size, struct page *page) > +void md_write_metadata(struct mddev *mddev, struct md_rdev *rdev, > + sector_t sector, int size, struct page *page, > + unsigned int offset) Maybe add a little command explaining what it does? > +extern void md_write_metadata(struct mddev *mddev, struct md_rdev *rdev, > + sector_t sector, int size, struct page *page, > + unsigned int offset); No need for the extern. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>