Re: [PATCH nf-next v2 1/2] netfilter: nf_tables: allow iter callbacks to sleep

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> > +		if (iter->count < iter->skip) {
> > +			iter->count++;
> > +			continue;
> > +		}
> 
> Not causing any harm, but is iter->count useful for this
> NFT_ITER_UPDATE variant?
>
> I think iter->count is only used for netlink dumps, to resume from the
> last netlink message.

Yes. Should I just remove the above or also add a WARN_ON_ONCE(iter->skip) ...

> > +	switch (iter->type) {
> > +	case NFT_ITER_UPDATE:

... here?




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux