On Wed, Jul 16, 2025 at 04:45:11PM +0200, Pablo Neira Ayuso wrote: > On Wed, Jul 16, 2025 at 04:43:02PM +0200, Pablo Neira Ayuso wrote: > > On Wed, Jul 16, 2025 at 04:39:54PM +0200, Pablo Neira Ayuso wrote: > > > On Wed, Jul 16, 2025 at 12:01:55PM +0200, Phil Sutter wrote: > > > > Hi, > > > > > > > > On Wed, Jul 16, 2025 at 11:44:59AM +0200, Florian Westphal wrote: > > > > > Phil Sutter <phil@xxxxxx> wrote: > > > > > > #include <string.h> > > > > > > #include <stdlib.h> > > > > > > +#include <libmnl/libmnl.h> > > > > > > > > > > Why is this include needed? > > > > > > > > Because of: > > > > > > > > | In file included from udata.c:9: > > > > | ../include/utils.h:88:40: warning: 'struct nlattr' declared inside parameter list will not be visible outside of this definition or declaration > > > > | 88 | const char *mnl_attr_get_ifname(struct nlattr *attr); > > > > | | ^~~~~~ > > > > > > I think this helper belongs to src/netlink.c This was about libnftnl, I put the helpers into src/utils.c there with nftnl_ prefix. > > Not a deal breaker, Florian's proposal is also fine. > > Actually, my suggestion would be to add it to nftables/src/mnl.c with > mnl_nft_ prefix (not to src/netlink.c), if it turns out this is useful > to other projects, it could be moved there to libnftnl. I also added it to nftables' src/mnl.c with mnl_ prefix, will change that to mnl_nft_ as suggested. Just realized nft.8 needs an update, too. Luckily, documentation is pretty forgiving when it comes to typos and other goofs. ;) Cheers, Phil
